Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add gh action workflow definition for F5 CLA automation #661

Closed
wants to merge 3 commits into from

Conversation

TasoOneAsia
Copy link
Member

Proposed changes

Adds a GH action workflow file (.github/workflows/f5-cla.yml) for F5 contributor license agreement (CLA) automation and compliance. This action is configured to target a shared signature store for F5 Open Source projects and will prompt contributors, upon pull request to main, to sign the F5 CLA if they have not already done so.

As part of the configuration for this project, the following GitHub usernames were whitelisted as maintainers:

  • Dean-Coakley
  • pleshakov
  • lucacome

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING
    guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@TasoOneAsia TasoOneAsia added the github_actions Pull requests that update Github_actions code label Mar 12, 2024
@TasoOneAsia TasoOneAsia self-assigned this Mar 12, 2024
@TasoOneAsia TasoOneAsia requested a review from a team as a code owner March 12, 2024 14:16
@lucacome lucacome added the chore Pull requests for routine tasks label Mar 12, 2024
Copy link
Contributor

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of CLAs, but 🤷‍♂️

@TasoOneAsia
Copy link
Member Author

@lucacome Should this get any additional reviews, or is this good to go?

@lucacome
Copy link
Contributor

@TasoOneAsia we require two approvals

@pdabelf5
Copy link
Collaborator

pdabelf5 commented Apr 9, 2024

Should this PR update the contributing guide to advise how to get approval for the F5 CLA?

@TasoOneAsia
Copy link
Member Author

@pdabelf5 Good call 👍

I'll update CONTRIBUTING to mention the CLA requirements and the agreement process.

@github-actions github-actions bot added documentation Pull requests/issues for documentation and removed chore Pull requests for routine tasks labels Apr 9, 2024
@TasoOneAsia TasoOneAsia added the chore Pull requests for routine tasks label Apr 9, 2024
@github-actions github-actions bot removed the chore Pull requests for routine tasks label Apr 11, 2024
@TasoOneAsia
Copy link
Member Author

Since this got the two approvals, I'll go ahead and squash + merge this on Monday if there are no objections.

@lucacome
Copy link
Contributor

lucacome commented Jun 6, 2024

@TasoOneAsia what is the status of this?

remote-repository-name: 'f5-cla-data'
path-to-signatures: 'signatures/beta/signatures.json'
# Comma seperated list of usernames for maintainers or any other individuals who should not be prompted for a CLA.
allowlist: Dean-Coakley, pleshakov, lucacome, bot*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if former employees need to sign the CLA or not, but we should probably remove Dean.

@lucacome
Copy link
Contributor

I'm going to close this since it's been open for 3+ months and there's no activity. Feel free to re-open it.

@lucacome lucacome closed this Jun 26, 2024
@TasoOneAsia
Copy link
Member Author

TasoOneAsia commented Jun 26, 2024

@lucacome Sorry about the delay in circling back to this, I'll update the branch to reflect a couple small changes that were made to the workflow recently and open up a new PR.

@lucacome
Copy link
Contributor

sounds good @TasoOneAsia thanks!

@TasoOneAsia TasoOneAsia deleted the ci/cla-automation branch July 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants