Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subrequest API requires data support and API updates. #34

Open
f5yacobucci opened this issue Jun 20, 2023 · 0 comments
Open

Subrequest API requires data support and API updates. #34

f5yacobucci opened this issue Jun 20, 2023 · 0 comments

Comments

@f5yacobucci
Copy link
Contributor

f5yacobucci commented Jun 20, 2023

Is your feature request related to a problem? Please describe.
During the development of a retry module gaps in the current subrequest API support were identified.

  • need getters for request status and subrequest depth
  • need to increment cycle count
  • the flags argument is not supported
  • the args argument is not supported
  • need to pass custom data to subrequest
  • do not automatically destroy subrequest body (allow caller to handle body lifetime)
  • suggested: provide a basic subrequest example module

Describe the solution you'd like
Add additional API support. This work has mostly been complete here but needs to be separated from the Event timer API work and linting updates. See the src/http/flags.rs and src/http/request.rs files for salient changes.

Additional context
Since this work is mostly completed by @avahahn and @f5yacobucci please see them for unclear details. This issue is a placeholder tracking issue to break apart an existing PR into its component features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant