Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple css classes to be specified using customErrorsClass #31

Closed
maxkrass opened this issue Feb 15, 2021 · 1 comment · Fixed by #54
Closed

Allow multiple css classes to be specified using customErrorsClass #31

maxkrass opened this issue Feb 15, 2021 · 1 comment · Fixed by #54
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@maxkrass
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Using the customErrorsClass directive, you can add one css class to the the control-error component. Specifying more than one class like so customErrorClass="classA classB" will result in no class being added to the component.

Expected behavior

The directive should allow for multiple classes to be added. Ideally in said fashion: customErrorClass="classA classB"

What is the motivation / use case for changing the behavior?

Frameworks like TailwindCSS and others usually require multiple css classes on one element to achieve a desired look and feel. So if you're in a utility first project, adding a single css class for multiple conceirns can be a bit of an anti-pattern.

@NetanelBasal NetanelBasal added enhancement New feature or request good first issue Good for newcomers labels Feb 16, 2021
@NetanelBasal
Copy link
Member

You're welcome to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants