Skip to content

optional dependency incorrect resolution #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okwme opened this issue Apr 22, 2025 · 2 comments
Closed

optional dependency incorrect resolution #179

okwme opened this issue Apr 22, 2025 · 2 comments

Comments

@okwme
Copy link

okwme commented Apr 22, 2025

SDK Version

1.5.0

What happened?

I'm using "vite-plugin-ngrok": "^1.1.2" which targets ngrok "@ngrok/ngrok" "^1.4.1" which resolves to version "1.5.0" which optionally includes @ngrok/ngrok-android-arm-eabi "1.5.0" which has no version 1.5 and so disrupts install to manually confirm the version 1.4.1 is fine.

I'm confused why ^1.4.1 would install version 1.5.0, it seems to all stem from that. Looking into the vite-plugin-ngrok repo, it has a pnpm-lock that seems to resolve a package with different integrity then when i install with yarn on my local machine.
https://github.com/aphex/vite-plugin-ngrok/blob/main/pnpm-lock.yaml

Relevant log output

@dthomasngrokker
Copy link
Contributor

Hi @okwme! The vite-plugin-ngrok is not maintained by us. You should open a ticket in the appropriate repo: https://github.com/aphex/vite-plugin-ngrok/issues

@dthomasngrokker dthomasngrokker closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2025
@okwme
Copy link
Author

okwme commented Apr 23, 2025

Hi @dthomasngrokker this error does not have to do with vite-plugin-ngrok, it's just where I encountered the issue. I have reproduced the issue without using the vite plugin as follows:

yarn add @ngrok/ngrok@^1.4.1

When running this command I'm prompted with the message:

Couldn't find any versions for "@ngrok/ngrok-android-arm-eabi" that matches "1.5.0"
? Please choose a version of "@ngrok/ngrok-android-arm-eabi" from this list: (Use arrow keys)
❯ 1.4.1
  1.4.0
  1.3.0
  1.2.0
  1.1.1
  1.1.0
  1.0.0
  0.9.1
  0.9.0
  0.8.0
  0.7.1
  0.7.0
  0.6.0
  0.5.2
  0.5.1
  0.5.0
  0.4.1
  0.4.0
  0.3.0
  0.2.0
  0.1.1
  0.1.0
  0.0.12
  0.0.11
  0.0.10
  0.0.9
  0.0.8
  0.0.7
  0.0.6

This is unexpected behaviour and I believe has to do with how versions of packages and dependencies are named within ngrok. It causes build errors on website deployments that do not expect a request and response style prompt.

A temporary solution is to overwrite my yarn.lock file with the expected version of 1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants