-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes applied to NgrokModuleSet
do not propagate to managed Edge
#287
Comments
Thank you for the report @pmalek ! Currently, the controller is watching Also, we are happy to look over a PR if you wanna explore the fix yourself. |
Thanks for response. I'll wait until you provide the fix as it's not obvious to me where and how to change (ingress controller https://github.com/ngrok/kubernetes-ingress-controller/blob/main/internal/controllers/ingress_controller.go I suppose) the code to make it work. |
What happened
After applying
NgrokModuleSet
with e.g. oauth set to google email address and changing the email address there's no change in the managedEdge
.What you think should happen instead
After applying
NgrokModuleSet
with e.g. oauth set to google email address and changing the email address, managedEdge
should be changedHow to reproduce
Apply (e.g. via
kubectl apply ...
) below listed manifest (substitute domain and email address with your own)Verify that you can access
<DOMAIN>
using<EMAIL>
address via google authentication.Change
<EMAIL>
to<EMAIL2>
and apply the changes (e.g.kubectl apply ...
)Verify that you can still access
<DOMAIN>
using<EMAIL>
address via google authentication and not via<EMAIL2>
The text was updated successfully, but these errors were encountered: