fix(schematics): fix unit tests for JSON with comments

ngrx · Jun 26, 2020 · 155ec1c · 155ec1c
1 parent f2af688
commit 155ec1c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/modules/schematics/src/entity/index.spec.ts b/modules/schematics/src/entity/index.spec.ts
@@ -240,9 +240,14 @@ describe('Entity Schematic', () => {
 
   describe('View engine', () => {
     beforeEach(() => {
-      const tsConfig = JSON.parse(
-        appTree.readContent('./projects/bar/tsconfig.app.json')
-      );
+      // remove the first line comment from the json file
+      const json = appTree
+        .readContent('./projects/bar/tsconfig.app.json')
+        .split('\n')
+        .slice(1)
+        .join('\n');
+      const tsConfig = JSON.parse(json);
+
       tsConfig.angularCompilerOptions = tsConfig.angularCompilerOptions || {};
       tsConfig.angularCompilerOptions.enableIvy = false;
       appTree.overwrite(

diff --git a/modules/schematics/src/reducer/index.spec.ts b/modules/schematics/src/reducer/index.spec.ts
@@ -12,7 +12,7 @@ import {
   defaultAppOptions,
 } from '../../../schematics-core/testing';
 
-describe('Reducer Schematic', () => {
+fdescribe('Reducer Schematic', () => {
   const schematicRunner = new SchematicTestRunner(
     '@ngrx/schematics',
     path.join(__dirname, '../../collection.json')
@@ -89,9 +89,14 @@ describe('Reducer Schematic', () => {
 
   describe('View engine', () => {
     beforeEach(() => {
-      const tsConfig = JSON.parse(
-        appTree.readContent('./projects/bar/tsconfig.app.json')
-      );
+      // remove the first line comment from the json file
+      const json = appTree
+        .readContent('./projects/bar/tsconfig.app.json')
+        .split('\n')
+        .slice(1)
+        .join('\n');
+      const tsConfig = JSON.parse(json);
+
       tsConfig.angularCompilerOptions = tsConfig.angularCompilerOptions || {};
       tsConfig.angularCompilerOptions.enableIvy = false;
       appTree.overwrite(