feat(effects): add support for effects of different instances of same…

… class (#1249) Closes #1246
ngrx · Aug 22, 2018 · 518e561 · 518e561
1 parent 1aa4b63
commit 518e561
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/modules/effects/spec/effect_sources.spec.ts b/modules/effects/spec/effect_sources.spec.ts
@@ -92,12 +92,23 @@ describe('EffectSources', () => {
     });
 
     it('should ignore duplicate sources', () => {
+      const sources$ = cold('--a--a--a--', {
+        a: new SourceA(),
+      });
+      const expected = cold('--a--------', { a });
+
+      const output = toActions(sources$);
+
+      expect(output).toBeObservable(expected);
+    });
+
+    it('should resolve effects from same class but different instances', () => {
       const sources$ = cold('--a--b--c--', {
         a: new SourceA(),
         b: new SourceA(),
         c: new SourceA(),
       });
-      const expected = cold('--a--------', { a });
+      const expected = cold('--a--a--a--', { a });
 
       const output = toActions(sources$);
 

diff --git a/modules/effects/src/effect_sources.ts b/modules/effects/src/effect_sources.ts
@@ -11,7 +11,6 @@ import {
 } from 'rxjs/operators';
 
 import { verifyOutput } from './effect_notification';
-import { getSourceForInstance } from './effects_metadata';
 import { resolveEffectSource } from './effects_resolver';
 
 @Injectable()
@@ -29,7 +28,7 @@ export class EffectSources extends Subject<any> {
    */
   toActions(): Observable<Action> {
     return this.pipe(
-      groupBy(getSourceForInstance),
+      groupBy(source => source),
       mergeMap(source$ =>
         source$.pipe(
           exhaustMap(resolveEffectSource),