refactor(example): remove @ngrx/db

format fixes as per PR
import order change as per PR
remove generic typing as per PR

Author: King-i

projects/example-app/src/app/books/effects/collection.effects.ts

@@ -1,16 +1,15 @@
 import { Injectable } from '@angular/core';
+import { Actions, Effect, ofType } from '@ngrx/effects';
+import { Action } from '@ngrx/store';
+import { defer, Observable, of } from 'rxjs';
+import { catchError, map, mergeMap, switchMap } from 'rxjs/operators';
+import { Book } from '@example-app/books/models/book';
 import {
   CollectionApiActions,
   CollectionPageActions,
   SelectedBookPageActions,
 } from '@example-app/books/actions';
-import { Book } from '@example-app/books/models/book';
 import { BookStorageService } from '@example-app/core/services/book-storage.service';
-import { Actions, Effect, ofType } from '@ngrx/effects';
-import { Action } from '@ngrx/store';
-import { defer, Observable, of } from 'rxjs';
-import { catchError, map, mergeMap, switchMap } from 'rxjs/operators';
-
 @Injectable()
 export class CollectionEffects {
   /**

projects/example-app/src/app/core/services/book-storage.service.spec.ts

@@ -40,6 +40,7 @@ describe('BookStorageService', () => {
       const expected = cold('(-a|)', { a: true });
       expect(fixture.supported()).toBeObservable(expected);
     });
+
     it('should throw error if localStorage provider  not available', () => {
       TestBed.resetTestingModule().configureTestingModule({
         providers: [
@@ -77,6 +78,7 @@ describe('BookStorageService', () => {
       );
       localStorageFake.setItem.mockClear();
     });
+
     it('should add multiple items', () => {
       const result = [...persistedCollection, book1, book3];
       const expected = cold('(-a|)', { a: result });
@@ -105,6 +107,7 @@ describe('BookStorageService', () => {
       );
       localStorageFake.getItem.mockClear();
     });
+
     it('should remove multiple items from collection', () => {
       const filterCollection = persistedCollection.filter(
         f => f.id !== book4.id
@@ -120,6 +123,7 @@ describe('BookStorageService', () => {
       );
       localStorageFake.getItem.mockClear();
     });
+
     it('should ignore items not present in collection', () => {
       const filterCollection = persistedCollection;
       const expected = cold('(-a|)', { a: filterCollection });

projects/example-app/src/app/core/services/book-storage.service.ts

@@ -11,11 +11,9 @@ import { Book } from '@example-app/books/models/book';
 export interface IBookStorageService {
   supported(): Observable<boolean>;
   deleteCollection(): Observable<boolean>;
-  addToCollection<T = Book>(records: T[]): Observable<T[]>;
+  addToCollection(records: Book[]): Observable<Book[]>;
   getCollection(): Observable<Book[]>;
-  removeFromCollection<T extends { id: string } = Book>(
-    ids: Array<string>
-  ): Observable<T[]>;
+  removeFromCollection<Book>(ids: Array<string>): Observable<Book[]>;
 }
 
 export const LOCAL_STORAGE_TOKEN = new InjectionToken(
@@ -32,28 +30,26 @@ export class BookStorageService implements IBookStorageService {
       : throwError('Local Storage Not Supported');
   }
 
-  getCollection<T = Book>(): Observable<T[]> {
+  getCollection(): Observable<Book[]> {
     return this.supported().pipe(
       map(_ => this.storage.getItem(this.collectionKey)),
       map((value: string | null) => (value ? JSON.parse(value) : []))
     );
   }
 
-  addToCollection<T = Book>(records: T[]): Observable<T[]> {
-    return this.getCollection<T>().pipe(
-      map((value: T[]) => [...value, ...records]),
-      tap((value: T[]) =>
+  addToCollection(records: Book[]): Observable<Book[]> {
+    return this.getCollection().pipe(
+      map((value: Book[]) => [...value, ...records]),
+      tap((value: Book[]) =>
         this.storage.setItem(this.collectionKey, JSON.stringify(value))
       )
     );
   }
 
-  removeFromCollection<T extends { id: string } = Book>(
-    ids: Array<string>
-  ): Observable<T[]> {
-    return this.getCollection<T>().pipe(
-      map((value: T[]) => value.filter(item => !ids.includes(item.id))),
-      tap((value: T[]) =>
+  removeFromCollection(ids: Array<string>): Observable<Book[]> {
+    return this.getCollection().pipe(
+      map((value: Book[]) => value.filter(item => !ids.includes(item.id))),
+      tap((value: Book[]) =>
         this.storage.setItem(this.collectionKey, JSON.stringify(value))
       )
     );