fix(signals): typing

Author: rainerhahnekamp

modules/signals/src/deep-freeze.ts

@@ -30,14 +30,14 @@ export function deepFreeze<T extends object>(target: T): T {
   return target;
 }
 
-export function freezeInDevMode<T>(target: T): T {
+export function freezeInDevMode<T extends object>(target: T): T {
   return ngDevMode ? deepFreeze(target) : target;
 }
 
 function hasOwnProperty(
   target: unknown,
-  propertyName: string
-): target is { [propertyName: string]: unknown } {
+  propertyName: string | symbol
+): target is { [propertyName: string | symbol]: unknown } {
   return isObjectLike(target)
     ? Object.prototype.hasOwnProperty.call(target, propertyName)
     : false;

modules/signals/src/signal-store-models.ts

@@ -11,9 +11,9 @@ export type StateSignals<State> = IsKnownRecord<Prettify<State>> extends true
     }
   : {};
 
-export type SignalsDictionary = Record<string, Signal<unknown>>;
+export type SignalsDictionary = Record<string | symbol, Signal<unknown>>;
 
-export type MethodsDictionary = Record<string, Function>;
+export type MethodsDictionary = Record<string | symbol, Function>;
 
 export type SignalStoreHooks = {
   onInit?: () => void;

modules/signals/src/with-state.ts

@@ -45,7 +45,7 @@ export function withState<State extends object>(
 
     const stateSignals = stateKeys.reduce((acc, key) => {
       const sliceSignal = computed(
-        () => (store[STATE_SOURCE]() as Record<string, unknown>)[key]
+        () => (store[STATE_SOURCE]() as Record<string | symbol, unknown>)[key]
       );
       return { ...acc, [key]: toDeepSignal(sliceSignal) };
     }, {} as SignalsDictionary);