-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schematics): correct a type of action class generated #1140
fix(schematics): correct a type of action class generated #1140
Conversation
In advance, I suppose the generated action class name
|
@MatsumotoKou Indeed, it should be generated as
|
I will commit additionally if needed, thank you. |
@tdeschryver |
@@ -69,6 +69,32 @@ describe('Action Schematic', () => { | |||
expect(fileContent).toMatch(/export enum FooActionTypes/); | |||
}); | |||
|
|||
it('should create a class named "LoadFoos"', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be more like should create a class based on the provided name
expect(fileContent).toMatch(/export class LoadFoos implements Action/); | ||
}); | ||
|
||
it('should create a type named "FooActions"', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be more like should create the union type based on the provided name
@brandonroberts |
Thanks! |
I used
ng generate action
command and found the generated file are invalid.Please check the result I generated, thank you.