Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoreDevtools): catch redux devtools errors #1450

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Yesterday a new version of the redux devtools was published and was leading to some problems as mentioned in #1449.

What is the new behavior?

This change wraps the redux devtools execution inside a try catch block, so that our applications can continue functioning as usual, but without the devtools.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts brandonroberts merged commit 4ed16cd into master Nov 29, 2018
@brandonroberts brandonroberts deleted the pr/devtools-errors branch November 29, 2018 13:37
@timdeschryver timdeschryver restored the pr/devtools-errors branch March 27, 2019 21:35
@timdeschryver timdeschryver deleted the pr/devtools-errors branch March 27, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants