feat(schematics): implement router store ng-add #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ng-add schematics, add schema implement tests Closes ngrx#1479
|
Preview docs changes for 51790c2 at https://previews.ngrx.io/pr1487-51790c2/ |
brandonroberts
requested changes
Dec 27, 2018
| "aliases": ["init"], | ||
| "factory": "./ng-add", | ||
| "schema": "./ng-add/schema.json", | ||
| "description": "Add router store class" |
There was a problem hiding this comment.
Update description to "Register @ngrx/router-store within your application"
| "description": "Allows specification of the declaring module.", | ||
| "alias": "m", | ||
| "subtype": "filepath" | ||
| } |
There was a problem hiding this comment.
The project key is missing here.
There was a problem hiding this comment.
The project keys are also missing in /modules/MODULE/schematics/ng-add/schema.json as they are merged with #1067, at least for effects, store or store-devtools. But for example in /modules/schematics/src/MODULE/schema.json they are included.
There was a problem hiding this comment.
Ok. That can be done in a separate PR.
add project property in collection.json change description in schema.json
|
Preview docs changes for 442109a at https://previews.ngrx.io/pr1487-442109a/ |
brandonroberts
approved these changes
Dec 28, 2018
ngfelixl
added a commit
to ngfelixl/platform
that referenced
this pull request
Dec 29, 2018
Add missing project keys to schema.json for store, store-devtools and effects Line-break remove related to "lint-staged" Related to ngrx#1487
3 tasks
|
Thanks @ngfelixl! |
brandonroberts
pushed a commit
that referenced
this pull request
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ng-add schematics for the router-store
add schema
implement tests
Closes #1479
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The user is not able to use Angular CLI to add the NgRX Router Store.
What is the new behavior?
The user is able to use Angular CLI to add the NgRX Router Store.
Does this PR introduce a breaking change?
Other information
Read the ng-add schematics implementation of the store-devtools and effects modules first. I have done this implementation with their code style in mind.
Is it correct to leave the module attribute inside the schema? Was not sure about this, since it just belongs in the root module, doesn't it? But the
store-devtoolsschematics provides a module specification as well, so I decided to leave it as is.