Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: update ofType #1687

Closed
timdeschryver opened this issue Apr 1, 2019 · 1 comment · Fixed by #1691
Closed

Example: update ofType #1687

timdeschryver opened this issue Apr 1, 2019 · 1 comment · Fixed by #1691
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Good First Issue Good issue for first-time contributor Project: Example App

Comments

@timdeschryver
Copy link
Member

With #1676 merged we can update the example app.

E.g. :

-- ofType(AuthActions.logoutConfirmation.type),
++ ofType(AuthActions.logoutConfirmation),

And also how the Actions are inject:

constructor(
--  private actions$: Actions<LoginPageActions.LoginPageActionsUnion>,
++  private actions$: Actions,
) {}
@wesleygrimes
Copy link
Contributor

I'm on it

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Good First Issue Good issue for first-time contributor Project: Example App
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants