Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routerStore): add v8 migration schematic #1699

Merged
merged 3 commits into from
Apr 9, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Add a schematic for the breaking change introduced in #1672.
Replace StoreRouterConnectingModule with StoreRouterConnectingModule.forRoot().

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Extract createReplaceChange and createChangeRecorder to schematics-core and refactor the store schematics.

Replace StoreRouterConnectingModule with StoreRouterConnectingModule.forRoot()
@brandonroberts
Copy link
Member

brandonroberts commented Apr 5, 2019

Will there be additional instructions needed for running these migrations? Something like

ng update @ngrx/router-store --migrate-only --from 7 --to 8

@timdeschryver
Copy link
Member Author

It should be sufficient with ng update @ngrx/store.
I'm not 100% sure of it and wanted to try it if we have a beta version.
I ran it via verdaccio locally, it picks up the migration file but it doesn't seem to execute the migration - I'm not sure if this is because of verdaccio or not since the schematic does work during the tests.

@brandonroberts
Copy link
Member

Hopefully we can cut a beta next week and test it with that.

@brandonroberts
Copy link
Member

TIL: angular/angular#29735

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 8, 2019

Preview docs changes for aeb26c0 at https://previews.ngrx.io/pr1699-aeb26c0/

@timdeschryver timdeschryver force-pushed the pr/router-store-migratin branch from aeb26c0 to c29249e Compare April 9, 2019 17:56
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 9, 2019

Preview docs changes for c29249e at https://previews.ngrx.io/pr1699-c29249e/

@brandonroberts brandonroberts merged commit 0b794ce into master Apr 9, 2019
@brandonroberts brandonroberts deleted the pr/router-store-migratin branch April 9, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants