Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schematics): add support for reducer creators #1785

Merged
merged 2 commits into from
Apr 23, 2019
Merged

feat(schematics): add support for reducer creators #1785

merged 2 commits into from
Apr 23, 2019

Conversation

brandonroberts
Copy link
Member

Closes #1764, 1766

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[x] No

Other information

Adds support for generating reducers using createReducer. Also consolidates using creator functions for actions, reducers, and effects into one flag, creators.

@brandonroberts brandonroberts mentioned this pull request Apr 23, 2019
Closed
@brandonroberts brandonroberts force-pushed the schematics-reducer-creators branch from f79c308 to 42097f0 Compare April 23, 2019 03:45
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 23, 2019

Preview docs changes for 42097f0 at https://previews.ngrx.io/pr1785-42097f0/

@brandonroberts brandonroberts force-pushed the schematics-reducer-creators branch from 42097f0 to a14d499 Compare April 23, 2019 04:20
@brandonroberts brandonroberts force-pushed the schematics-reducer-creators branch from a14d499 to 9e40709 Compare April 23, 2019 04:23
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 23, 2019

Preview docs changes for a14d499 at https://previews.ngrx.io/pr1785-a14d499/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 23, 2019

Preview docs changes for 9e40709 at https://previews.ngrx.io/pr1785-9e40709/

timdeschryver
timdeschryver approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit

modules/schematics/src/effect/schema.json Outdated Show resolved Hide resolved
@timdeschryver @brandonroberts
chore: update effect schema description
ceab87d 
Co-Authored-By: brandonroberts <robertsbt@gmail.com>
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 23, 2019

Preview docs changes for ceab87d at https://previews.ngrx.io/pr1785-ceab87d/

@brandonroberts brandonroberts merged commit 8a0a049 into master Apr 23, 2019
@brandonroberts brandonroberts deleted the schematics-reducer-creators branch April 23, 2019 12:05
@brandonroberts brandonroberts mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schematics: add schematics for reducer creators
3 participants
@brandonroberts @ngrxbot @timdeschryver