Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: createSelectorFactory should be returning MemoizedSelector instead of Selector #1849

Closed
alex-okrushko opened this issue May 10, 2019 · 0 comments · Fixed by #1883
Closed

store: createSelectorFactory should be returning MemoizedSelector instead of Selector #1849

alex-okrushko opened this issue May 10, 2019 · 0 comments · Fixed by #1883
Assignees
@alex-okrushko @timdeschryver
Labels
Project: Store

Comments

@alex-okrushko
Copy link
Member

That causes some issues with testing these selectors, because Selector signature does not provide projector method, even those technically it exists.

Current workaround is to cast it.

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-okrushko alex-okrushko

@timdeschryver timdeschryver

Labels
Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: createSelectorFactory should return a MemoizedSelector ngrx/platform
2 participants
@alex-okrushko @timdeschryver