Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockStore: props are dropped when MockStore is passing selectors to actual Store #1864

Closed
alex-okrushko opened this issue May 16, 2019 · 1 comment

Comments

@alex-okrushko
Copy link
Member

Uncovered during the merge: selectors with Props were getting undefined instead of the prop values.
This is happening because MockStore wasn't taking Props in the select implementation, so it's not passing anything down to the Store as well.

select(selector: any) {

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@alex-okrushko
Copy link
Member Author

That's v8 blocker, btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant