Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(Store): store should fail synchronously #1871

Merged
merged 2 commits into from
May 17, 2019

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented May 17, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

What is the current behavior?

Closes #1865

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This commit partially reverts commit 60633b7

These changes were made in context to test runtime checks. @alex-okrushko pointed out that this change broke some of the google tests. This PR reverts the store subscription and rewrites the runtime checks.

cc @alex-okrushko

@brandonroberts brandonroberts merged commit 59a9e6c into master May 17, 2019
@brandonroberts brandonroberts deleted the pr/revert-state-subscription branch May 17, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store should fail synchronously when dispatching an action that triggers reducer to throw error
3 participants