Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-store): remove circular depedency in serializers #1904

Merged
merged 1 commit into from
Jun 1, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1902

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

To be honest, I have no idea why this was a circular dependency 😅.
Importing serializer via their specific file names (e.g. ./serializers/default_serializer) in router_store_module.ts resolved this issue. To be safe I removed the entry file ./serializers/index and pointed every import to the specific file.

Also renamed shared to base as it felt weird to import from /shared.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 1, 2019

Preview docs changes for b606431 at https://previews.ngrx.io/pr1904-b606431/

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix against a local reproduction of the issue

@brandonroberts brandonroberts merged commit 0407c5b into master Jun 1, 2019
@brandonroberts brandonroberts deleted the pr/fix-circ-dep branch June 1, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue upgrading to 8.0.0-rc.0
3 participants