feat(effects): createEffect returns specific type for dispatch false #2195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
based of #2194
createEffect
with{dispatch: false}
now returns whatever Observable type is actually returned (instead ofunknown
).What is the current behavior?
createEffect
with{dispatch: false}
returnsObservable<unknown>
.What is the new behavior?
createEffect
with{dispatch: false}
returnsObservable<SpecificType>
.Does this PR introduce a breaking change?
Somewhat. If anyone was relying that
Observable<unknown>
is returned. However,Observable<SpecificType>
can be always widened toObservable<unknown>
so it shouldn't really break anything.Other information