Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): initial setup #2257

Merged
merged 2 commits into from
Jan 7, 2020
Merged

feat(component): initial setup #2257

merged 2 commits into from
Jan 7, 2020

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Nov 13, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Ticks off a checkbox from #2223

What is the new behavior?

Adds the initial setup for @ngrx/component.
I left some TODO's for later.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

timdeschryver
timdeschryver commented Nov 13, 2019
View reviewed changes
build/tasks.ts
@@ -18,7 +18,10 @@ export async function copySchematicsCore(config: Config) {
.toString('utf-8');
const pkgConfig = JSON.parse(packageJson);

if (pkgConfig.schematics || pkgConfig['ng-update'].migrations) {
if (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component doesn't have schematics, pkgConfig['ng-update'].migrations threw an error.

@timdeschryver
Copy link
Member Author

I suppose the build repo has to be created before we merge this in.

@brandonroberts
Copy link
Member

The component-builds repo has been created.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 14, 2019 •
edited
Loading

Preview docs changes for a8089ac at https://previews.ngrx.io/pr2257-a8089ac/

@brandonroberts brandonroberts merged commit b8a769a into master Jan 7, 2020
@brandonroberts brandonroberts deleted the ngrx-component branch January 7, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
9.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timdeschryver @brandonroberts @ngrxbot