refactor minimal option #2258
Merged
refactor minimal option #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @brandonroberts |
|
Preview docs changes for 54b14c0 at https://previews.ngrx.io/pr2258-54b14c0/ |
There was a problem hiding this comment.
I think you have changed the wrong schematic.
We have generate schematics (ng generate store) and ng-add schematics (ng add @ngrx/store), this change should only affect the ng-add schematics.
These schematics are located at https://github.com/ngrx/platform/blob/master/modules/store/schematics/ng-add/schema.json#L41
Jefiozie
force-pushed
the
2250-minimal-store
branch
from
f59c90e to
2dfc95a
Compare
timdeschryver
approved these changes
Nov 14, 2019
|
@Jefiozie could you also add a breaking change note to the PR please, you can find a template in CONTRIBUTING.MD |
Closes ngrx#2250 BREAKING CHANGES: With this change by default the minimal setup for `ngrx/store` will be generated. BEFORE: ``` @NgModule({ declarations: [ AppComponent, ], imports: [ BrowserModule, StoreModule.forRoot(reducers, { metaReducers, runtimeChecks: { strictStateImmutability: true, strictActionImmutability: true } }), ..... ], providers: [], bootstrap: [AppComponent] }) ``` AFTER: ``` @NgModule({ declarations: [ AppComponent, ], imports: [ BrowserModule, StoreModule.forRoot({}) .... ], providers: [], bootstrap: [AppComponent] }) ```
Jefiozie
force-pushed
the
2250-minimal-store
branch
from
2dfc95a to
54b14c0
Compare
|
Added the breaking change request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
It will introduce a breaking change based on the flag option that has been changed.
What is the current behavior?
By default the minimal flag is false.
Closes #2250
What is the new behavior?
By default the minimal flag is true
Does this PR introduce a breaking change?
Other information