Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-devtools): escaping the safelist and blocklist strings #2259

Merged

Conversation

evgenyfedorenko
Copy link
Contributor

Closes #2228

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2228

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 14, 2019

Preview docs changes for 65b785a at https://previews.ngrx.io/pr2259-65b785a/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this won't work if multiple action types are added to the safe or block list.

@evgenyfedorenko
Copy link
Contributor Author

I believe this won't work if multiple action types are added to the safe or block list.

Good catch. Added a fix for a fix.

@brandonroberts brandonroberts merged commit e888977 into ngrx:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store-devtools: actionsBlocklist issue with regex-like strings
4 participants