Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: create presskit page #2296

Merged
merged 1 commit into from
Jan 24, 2020
Merged

docs: create presskit page #2296

merged 1 commit into from
Jan 24, 2020

Conversation

jordanpowell88
Copy link
Contributor

Closes #2293

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No Link

Closes #2293

What is the new behavior?

Add link in footer for Diagram PSD

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Dec 19, 2019 •
edited
Loading

Preview docs changes for e699bc8 at https://previews.ngrx.io/pr2296-e699bc8/

@brandonroberts
Copy link
Member

Instead of adding this as an individual link, I think we should create a "Diagrams" or "Press Kit" type page to put these assets.

@brandonroberts brandonroberts added the WIP Not ready for review label Jan 7, 2020
@timdeschryver
Copy link
Member

timdeschryver commented Jan 7, 2020 •
edited
Loading

A page familiar to https://angular.io/presskit where we can also upload the NgRx logo 🙂 is what I had in mind.

@jordanpowell88 jordanpowell88 force-pushed the add-diagram-psd branch 2 times, most recently from 2658d3c to 87a5d52 Compare January 14, 2020 02:25
@jordanpowell88 jordanpowell88 changed the title docs: add lifecycle diagram psd to footer docs: create presskit page Jan 14, 2020
@jordanpowell88
Copy link
Contributor Author

@brandonroberts @timdeschryver I'm getting a build error saying unmatched links. The links work correctly when I run the app locally. Is their a script I have to run to get this build to work?

timdeschryver
timdeschryver reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR misses the state-management-lifecycle.png file?
I haven't taken a look at it, but this might be the cause of the errors.

@jordanpowell88
Copy link
Contributor Author

@timdeschryver I fixed the previous issue but now I'm getting some strange build issue when the test run. The test as passing but looks like the code coverage part fails. Any ideas?

brandonroberts
brandonroberts requested changes Jan 21, 2020
View reviewed changes
projects/ngrx.io/content/marketing/presskit.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/marketing/presskit.md Outdated
Logo (svg) - <a href="#">Download</a>
</div>

## Diagram PSD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Diagram PSD
## State Management Lifecycle Diagram PSD

projects/ngrx.io/content/navigation.json Outdated Show resolved Hide resolved
projects/ngrx.io/content/navigation.json Outdated Show resolved Hide resolved
@brandonroberts
Copy link
Member

@jordanpowell88 you need to rebase on master to fix the CI test issue.

@jordanpowell88 jordanpowell88 force-pushed the add-diagram-psd branch 2 times, most recently from 52407df to a382527 Compare January 22, 2020 00:01
timdeschryver
timdeschryver reviewed Jan 22, 2020
View reviewed changes
projects/ngrx.io/content/marketing/presskit.md Outdated
## NgRx Logo
<img src="assets/images/ngrx-badge.png" width="100" style="float:left; padding-right: 1rem;" />
<div style="padding-top:1rem;">
Logo (png) - <a href="#">Download</a><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to add href to the logo here, otherwise it won't download.
The same for the other logos.

projects/ngrx.io/content/marketing/presskit.md Outdated
## State Management Lifecycle Diagram PSD

<img src="generated/images/guide/store/state-management-lifecycle.png" width="100" style="float:left; padding-right: 1rem;" />
Diagram (psd) - <a href="generated/images/guide/store/state-management-lifecycle.psd">Download</a><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a download attribute?
It will download the file instead of opening it in the same window.

Suggested change
Diagram (psd) - <a href="generated/images/guide/store/state-management-lifecycle.psd">Download</a><br />
Diagram (psd) - <a href="generated/images/guide/store/state-management-lifecycle.psd" download>Download</a><br />

@brandonroberts brandonroberts removed the WIP Not ready for review label Jan 24, 2020
@brandonroberts brandonroberts merged commit 9ac1165 into ngrx:master Jan 24, 2020
@brandonroberts brandonroberts mentioned this pull request Jan 24, 2020
Closed
2 tasks
@jordanpowell88 jordanpowell88 deleted the add-diagram-psd branch January 24, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add link to Diagram PSD
4 participants
@jordanpowell88 @ngrxbot @brandonroberts @timdeschryver