Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): allow additional selectors in entitySelectors$ #2332

Conversation

luchillo17
Copy link
Contributor

@luchillo17 luchillo17 commented Jan 24, 2020

#2324 Allowing random selectors so selectors created based on entity metadata's additionalCollectionState can be accessed without casting to any.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 24, 2020

Preview docs changes for c124967 at https://previews.ngrx.io/pr2332-c124967/

Copy link
Contributor

@wardbell wardbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timdeschryver timdeschryver changed the title fix(data): Allow random selectors in entitySelectors$ fix(data): allow additional selectors in entitySelectors$ Jan 24, 2020
@timdeschryver timdeschryver merged commit 900bf75 into ngrx:master Jan 24, 2020
@luchillo17 luchillo17 deleted the hotfix/#2324-additionalCollectionState-selectors branch January 24, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants