-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Entity) Deprecate addAll and rename it to setAll #2348
Conversation
@@ -200,6 +210,7 @@ export function createSortedStateAdapter<T>(selectId: any, sort: any): any { | |||
updateOne: createStateOperator(updateOneMutably), | |||
upsertOne: createStateOperator(upsertOneMutably), | |||
addAll: createStateOperator(addAllMutably), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should rename addAllMutalby
to setAllMutable
and just point addAll
and setAll
to createStateOperator(setAllMutably).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Preview docs changes for 2ecd958 at https://previews.ngrx.io/pr2348-2ecd958/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also change the schematics and @ngrx/data (can be done in separate PRs?)
Schematics:
Data:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @elvisun! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently
addAll
removes all existing entities and then add all, which is very confusing and bug-prone.Closes #2330
What is the new behavior?
Deprecated
addAll
and added an identicalsetAll
Does this PR introduce a breaking change?
Other information