Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): wrong type of filter #2349

Merged
merged 1 commit into from
Feb 8, 2020
Merged

fix(data): wrong type of filter #2349

merged 1 commit into from
Feb 8, 2020

Conversation

santoshyadavdev
Copy link
Contributor

Fixes #2337

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2337

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 6, 2020

Preview docs changes for 731c447 at https://previews.ngrx.io/pr2349-731c447/

@santoshyadavdev
Copy link
Contributor Author

The test cases are fine locally, can we run them again.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I wonder if setFilter should expect a string instead of `any.

@brandonroberts brandonroberts merged commit 94f3ef1 into ngrx:master Feb 8, 2020
@santoshyadavdev santoshyadavdev deleted the fix(data)---wrong-type-of-filter$ branch May 6, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@ngrx/data] - wrong type of filter$
4 participants