Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(effects): dispatch OnInitEffects action after registration #2386

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Feb 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2373

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The problem wasn't Ivy, but that the action was dispatched before the registration of the effect sources. The action was dispatched, but the effects didn't catch this action because it was dispatched too early.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 18, 2020

Preview docs changes for e28c446 at https://previews.ngrx.io/pr2386-e28c446/

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit daf1e64 into master Feb 18, 2020
@brandonroberts brandonroberts deleted the pr/fix-init-effects branch February 18, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ivy] 9.0.0-beta.0 - Life Cycle Effects Hook loses context
3 participants