Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng add @ngrx/store -> Unexpected token / in JSON at position 173 #2478

Closed
PooSham opened this issue Apr 7, 2020 · 3 comments
Closed

ng add @ngrx/store -> Unexpected token / in JSON at position 173 #2478

PooSham opened this issue Apr 7, 2020 · 3 comments

Comments

@PooSham
Copy link

PooSham commented Apr 7, 2020

Minimal reproduction of the bug/regression with instructions:

When I run ng add @ngrx/store, I get the following error:

Unexpected token / in JSON at position 173

and StoreModule is not added to my imports in the app module.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

Here's the output from ng version

Angular CLI: 9.0.1
Node: 10.16.2
OS: win32 x64

Angular: 9.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package Version

@angular-devkit/architect 0.900.1
@angular-devkit/build-angular 0.900.1
@angular-devkit/build-optimizer 0.900.1
@angular-devkit/build-webpack 0.900.1
@angular-devkit/core 9.0.1
@angular-devkit/schematics 9.0.1
@angular/cli 9.0.1
@ngtools/webpack 9.0.1
@schematics/angular 9.0.1
@schematics/update 0.900.1
rxjs 6.5.3
typescript 3.6.4
webpack 4.39.1

I would be willing to submit a PR to fix this issue

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ X ] No

@timdeschryver
Copy link
Member

I hope #2455 fixes this issue.
When a new version is released, I will give it a spin and see what happens.

@timdeschryver
Copy link
Member

timdeschryver commented Apr 7, 2020

@PooSham we just release v9.1 and this issue seems to be resolved.
If this is not the case, fee free to reopen this issue.

@PooSham
Copy link
Author

PooSham commented Apr 9, 2020

I still get this issue in v9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants