fix(component): removed ivy checks as obsolete #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for bc20593 at https://previews.ngrx.io/pr2579-bc205933/ |
alex-okrushko
requested changes
Jun 14, 2020
There was a problem hiding this comment.
#2547 removes isNgZone and adjusts hasZone - and uses it instead.
Could you please adjust the Pr to only remove Ivy-related files?
|
There are merge conflicts that need to be fixed up here also. |
BioPhoton
force-pushed
the
remove-global-this
branch
from
bc1c684 to
9851f60
Compare
BioPhoton
force-pushed
the
remove-global-this
branch
from
9851f60 to
bc20593
Compare
brandonroberts
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused checks and tests
closes #2575