fix(router-store): ignore trailing slash when comparing routes #2834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Ignore trailing slash (
/
) when comparing URLs in thenavigateIfNeed
method of therouter-store
.What is the current behavior?
proceeds with re-navigation, which can lead to infinite loop if there's a guard on
/
or `` path (root).Closes #2829
What is the new behavior?
Doesn't navigate if the changes in Store lead to the URL being the same as the current one (previously only the exact match would've prevented it).
Does this PR introduce a breaking change?
Other information