Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose FunctionWithParametersType #2988

Merged

Conversation

jordanpowell88
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The only way to reference FunctionWithParametersType currently is to do a deep import of @ngrx/store/src/models.

Closes #2983

What is the new behavior?

This PR would expose FunctionWithParametersType without the need for a deep import. ie: @ngrx/store

Does this PR introduce a breaking change?

[ ] Yes
[X ] No

Other information

Can we patch this change with other versions (8+) as well?

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 6, 2021

Preview docs changes for 694a55e at https://previews.ngrx.io/pr2988-694a55ed/

@brandonroberts brandonroberts merged commit fe7d058 into ngrx:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Expose FunctionWithParametersType
3 participants