Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): move createEffect migration to ng-update migration #3074

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
BREAKING CHANGE:

The create-effect-migration migration is removed

Other information

@timdeschryver timdeschryver changed the title feat(effect): move createEffect migration to ng-update migration feat(effects): move createEffect migration to ng-update migration Jul 20, 2021
BREAKING CHANGE:

The create-effect-migration migration is removed
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 20, 2021

Preview docs changes for 96fe7b8 at https://previews.ngrx.io/pr3074-96fe7b8c/

Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇 👀

@brandonroberts brandonroberts merged commit 5974913 into master Nov 1, 2021
@brandonroberts brandonroberts deleted the effects-migration branch November 1, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants