fix(store): infer initial store state properly with metareducers #3102

timdeschryver · 2021-07-29T05:04:42Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3007

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

This will probably be a breaking change because we're more strict.

BREAKING CHANGE:

`initialState` needs to match the interface of the store.

Other information

BREAKING CHANGE: `initialState` needs to match the interface of the store.

ngrxbot · 2021-07-29T05:11:37Z

Preview docs changes for e045328 at https://previews.ngrx.io/pr3102-e0453285/

markostanimirovic · 2021-07-30T08:54:21Z

modules/store/spec/types/store_module.spec.ts

+import { expecter } from 'ts-snippet';
+import { compilerOptions } from './utils';
+
+describe('StoreModule', () => {


Thanks for adding the label, I always forgot to do that 🤦‍♂️

fix(store): infer initial store state properly with metareducers

e045328

BREAKING CHANGE: `initialState` needs to match the interface of the store.

timdeschryver force-pushed the 3007 branch from aa7c859 to e045328 Compare July 29, 2021 05:04

markostanimirovic approved these changes Jul 30, 2021

View reviewed changes

markostanimirovic added the Breaking Change label Jul 30, 2021

brandonroberts approved these changes Nov 2, 2021

View reviewed changes

brandonroberts merged commit d003b85 into master Nov 2, 2021

timdeschryver deleted the 3007 branch November 2, 2021 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(store): infer initial store state properly with metareducers #3102

fix(store): infer initial store state properly with metareducers #3102

timdeschryver commented Jul 29, 2021

ngrxbot commented Jul 29, 2021

markostanimirovic Jul 30, 2021

timdeschryver Jul 30, 2021

fix(store): infer initial store state properly with metareducers #3102

fix(store): infer initial store state properly with metareducers #3102

Conversation

timdeschryver commented Jul 29, 2021

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

ngrxbot commented Jul 29, 2021

markostanimirovic Jul 30, 2021

Choose a reason for hiding this comment

timdeschryver Jul 30, 2021

Choose a reason for hiding this comment