-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add createFeatureSelector migration #3214
Conversation
Preview docs changes for 1d1fef8 at https://previews.ngrx.io/pr3214-1d1fef81/ |
@@ -15,6 +15,11 @@ | |||
"description": "The road to v8 RC", | |||
"version": "8-rc.1", | |||
"factory": "./8_0_0-rc/index" | |||
}, | |||
"ngrx-store-migration-13-beta": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the previous migration names:
"ngrx-store-migration-13-beta": { | |
"ngrx-store-migration-04": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea... 😅
The name doesn't really matter (it's only important to run the schematic in the test).
I was thinking it would make more sense to follow the versions, instead of creating an own counter.
@timdeschryver will this handle |
@brandonroberts that should be covered. I'll add a test later today. |
@brandonroberts @markostanimirovic I've added the test in the last commit. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Adds a migration to update the deprecated
createFeatureSelector
syntax: