Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): remove store config from forFeature signature with slice #3218

Merged

Conversation

markostanimirovic
Copy link
Member

@markostanimirovic markostanimirovic commented Nov 2, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The StoreModule.forFeature signature with FeatureSlice has StoreConfig as the second input argument, but the configuration isn't registered if passed.

Closes #3216

What is the new behavior?

The StoreModule.forFeature signature with FeatureSlice no longer has StoreConfig as the second input argument.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGES:

The `StoreConfig` argument is removed from the `StoreModule.forFeature` signature with `FeatureSlice`.

BEFORE:

The `StoreModule.forFeature` signature with `FeatureSlice` has `StoreConfig` as the second input argument, but the configuration isn't registered if passed.

AFTER:

The `StoreModule.forFeature` signature with `FeatureSlice` no longer has `StoreConfig` as the second input argument.

BREAKING CHANGES:

The `StoreConfig` argument is removed from the `StoreModule.forFeature` signature with `FeatureSlice`.

BEFORE:

The `StoreModule.forFeature` signature with `FeatureSlice` has `StoreConfig` as the second input argument, but the configuration isn't registered if passed.

AFTER:

The `StoreModule.forFeature` signature with `FeatureSlice` no longer has `StoreConfig` as the second input argument.
@ngrxbot
Copy link
Collaborator

ngrxbot commented Nov 2, 2021

Preview docs changes for f58d4d8 at https://previews.ngrx.io/pr3218-f58d4d8b/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a type test here ?

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brandonroberts brandonroberts merged commit b1a64dd into ngrx:master Nov 3, 2021
@markostanimirovic markostanimirovic deleted the fix/store/remove-slice-config branch November 10, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metaReducers don't work in forFeature module when using createFeature
4 participants