feat(schematics): remove creators option #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
timdeschryver
commented
Feb 8, 2022
| expect(content).toMatch( | ||
| /import \{ FooActionTypes, FooActions } from '\.\.\/\.\.\/actions\/foo\/foo\.actions';/ | ||
| ); | ||
| expect(content).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
toMatchInlineSnapshot is used here because it was easier to see what was going on (and wrong).
...tics/src/action/files/__name@dasherize@if-flat__/__name@dasherize__.actions.spec.ts.template
Outdated
Show resolved
Hide resolved
timdeschryver
force-pushed
the
remove-non-creator-schematics
branch
from
6de2ef9 to
efe9a27
Compare
timdeschryver
force-pushed
the
remove-non-creator-schematics
branch
from
efe9a27 to
d6fbb76
Compare
markostanimirovic
approved these changes
Mar 9, 2022
brandonroberts
approved these changes
May 18, 2022
BREAKING CHANGE: BEFORE: Creating actions, reducers, and effects is possible without using the creators syntax is possible. AFTER: All schematics use the non-creators syntax to scaffold the code. The option `--creators` (and `-c`) is removed from the schematic options.
BREAKING CHANGE: The `skipTests` option is removed while generating actions. Action spec files are not generated.
timdeschryver
force-pushed
the
remove-non-creator-schematics
branch
from
d6fbb76 to
123a84f
Compare
|
Thanks for the reminder @brandonroberts , should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information