Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add NgRx ESLint Plugin #3373

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Apr 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Partially #3372

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

image

image

@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 0274817
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62598cd773be08074cc84758
😎 Deploy Preview https://deploy-preview-3373--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@timdeschryver timdeschryver changed the title Eslint ngrx feat(eslint-plugin): add NgRx ESLint Plugin Apr 12, 2022
@timdeschryver timdeschryver added the WIP Not ready for review label Apr 13, 2022
@timdeschryver
Copy link
Member Author

I removed the WIP label because this is ready to be reviewed now.
Added a couple of screenshots to the description.

@timdeschryver timdeschryver removed the WIP Not ready for review label Apr 15, 2022
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@brandonroberts brandonroberts merged commit ae0041b into master Apr 18, 2022
@timdeschryver timdeschryver deleted the eslint-ngrx branch April 18, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants