-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add createActionGroup function #3381
feat(store): add createActionGroup function #3381
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
3226f65
to
ab015d6
Compare
ab015d6
to
bcc5d2c
Compare
} from '@ngrx/store'; | ||
import { TypedAction } from './models'; | ||
|
||
// Generating API docs for the `createActionGroup` function is solved by moving its types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was the same bug with generating API docs for the createActionGroup
function as there was for the createFeature
- template literal types. I moved its types to another file to make API generation work.
I've been doing a version of this for years on my own in each NGRX project that I've worked on, so I'm beyond happy to find out that this is part of the core lib now 🎉 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3337
What is the new behavior?
Does this PR introduce a breaking change?