feat(schematics): use schematicCollections instead of defaultCollection #3441
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
| ...value, | ||
| }; | ||
| if (!(workspace['cli'] && workspace['cli']['schematicCollections'])) { | ||
| throw new Error( |
There was a problem hiding this comment.
Why are we throwing an error here? If the schematicCollections property doesn't exist, we should create it and add @ngrx/schematics to it.
There was a problem hiding this comment.
That would be on me 😅
#3383 (comment)
There was a problem hiding this comment.
Since it's 2vs1, I'm fine with creating the property.
I don't know what Angular's schematic will do with it though (in the case that NgRx is updated before Angular)
There was a problem hiding this comment.
Ahh ok. I was thinking of cases like Nx where it may not be present, but I think they account for that anyway. Throwing the error should be ok for now
There was a problem hiding this comment.
Looks good to me!
After this, we should also update the docs.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3383
What is the new behavior?
Throw an exception if schematicCollections is not defined because the user may not have upgraded Angular to v14.
Does this PR introduce a breaking change?
Other information