feat(effects): add provideEffects function #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
markostanimirovic
force-pushed
the
feat/effects/provide-effects
branch
from
8e547f0 to
a011fe6
Compare
| useValue: () => { | ||
| const effectsRunner = inject(EffectsRunner); | ||
| const effectSources = inject(EffectSources); | ||
| const shouldInitEffects = !effectsRunner.isStarted; |
There was a problem hiding this comment.
We should use a provider token here that checks to see if there is a parent token above this injector. If not then start the effects and we don't have to use property on the class
There was a problem hiding this comment.
I'm not sure it would work when provideEffects is called multiple times within the context of the same injector.
markostanimirovic
force-pushed
the
feat/effects/provide-effects
branch
2 times, most recently
from
639ed71 to
3898d51
Compare
markostanimirovic
force-pushed
the
feat/effects/provide-effects
branch
from
3898d51 to
e4f5767
Compare
timdeschryver
approved these changes
Aug 24, 2022
|
🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3522
What is the new behavior?
Does this PR introduce a breaking change?