Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): avoid-mapping-selectors don't report on ThisExpression #3546

Merged

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Aug 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3511

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This scans if this is used in an operator.
If it finds a this, then the avoid-mapping-selectors rule is disabled.
The reasoning behind this, is that the selector is used in combination with something from the component (which can't be moved into the selector) to do something.

@netlify
Copy link

netlify bot commented Aug 25, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 3d0e515
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6307d1d8cb0a1c0008ee64da
😎 Deploy Preview https://deploy-preview-3546--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markostanimirovic markostanimirovic merged commit a28175c into master Aug 28, 2022
@timdeschryver timdeschryver deleted the eslint-plugin/avoid-mapping-selectors-higher-order branch September 27, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of @ngrx/avoid-mapping-selectors lint rule
3 participants