-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component-store: Debounce stops working correctly with RXJS 7.5.x #3554
Comments
I don't think we can do anything about it - it's a broken upstream dependency. |
Replacing |
Any updates on this issue? Thanks |
Debounce: false isn't really a valid workaround, since you're changing how the code works. If it works without debouncing, you didn't need it to begin with. The people from rxjs closed the issue about what was/is causing problems, since it "should" be fixed starting from 7.5.7, but this is still not the case for our project. |
Any update? |
They (the people from rxjs) have -allegedly- fixed it for their next release but it hasn't come out yet. |
Thank you @aldrashan |
@thomastrapanese |
It seems this issue is fixed in RxJS v7.8.1. |
Minimal reproduction of the bug/regression with instructions
Will try to create a minimal example that displays the problem later.
Our code library isn't quickly exportable right now.
https://stackblitz.com/edit/rxjs-htf8tz?file=index.ts should show this as well (from the issue linked below).
Minimal reproduction of the bug/regression with instructions
See ReactiveX/rxjs#6747.
I too traced our issues down to the asapScheduler that's used in the debounceSync function.
https://github.com/ngrx/platform/blob/master/modules/component-store/src/debounce-sync.ts
-> Line 53: observer.next(actionValue); is never hit in some cases
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)
NgRx: 14
Angular: 14
Node: n/a
Browsers: n/a
OS: n/a
Other information
No response
I would be willing to submit a PR to fix this issue
The text was updated successfully, but these errors were encountered: