Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnknownNumberParsing doesn't include integers #148

Open
ghost opened this issue Nov 28, 2019 · 2 comments
Open

UnknownNumberParsing doesn't include integers #148

ghost opened this issue Nov 28, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 28, 2019

I wonder why integers are not considered in:

public enum UnknownNumberParsing {
		LONG_AND_BIGDECIMAL,
		LONG_AND_DOUBLE,
		BIGDECIMAL,
		DOUBLE
	}

In terms of memory usage it would be a big improvement for those scenarios where the json schema is unknown.

Thanks

@zapov
Copy link
Member

zapov commented Nov 28, 2019

Well, I did not consider it a big improvement, as it's already boxed and put in a map.
But sure, if people want to have it, its fine that there is also something along the lines of MINIMAL_SIZE which would translate to short/int/long/float/double/big decimal
I have no real use for that, so PR is welcome

@ghost
Copy link
Author

ghost commented Nov 29, 2019

Thank you very much for your response, if I end up using this library I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant