Create an Http service extension

[sinedied]

Provide support for server configuration depending of the environment, default headers and user-configurable cache policy.

Should go in core module.

[moshmage]

How would I go about extending this?
I tried to provide a AuthService (which holds a Authorization: Bearer <token>), and then (on private httpRequest) made an extend({}, options, { headers: new Headers('Authorization', this.authService.token) })

but the constructor never get the authService (comming with undefined as its value on a console.log)

What I did:

• core.module.ts add authService to the providers
• add authService to the createHttpService return function
• add authService to http.service.ts constructor
• console.log(authService)
• ???
• don't profit because it comes out undefined :(

What I'm trying to do:
Hook the "Authorization: Bearer <token>" header to every http request call

... Further down the line I'll need to hook on every 401 answer so I know when the is no longer valid; But Ill cross that bridge when I get there :)

[sinedied]

Seems like an injection issue, is your core.module.ts createHttpService like this

export function createHttpService(backend: ConnectionBackend,
                                  defaultOptions: RequestOptions,
                                  httpCacheService: HttpCacheService,
                                  authService: AuthService) {
  return new HttpService(backend, defaultOptions, httpCacheService, authService);
}

and your HttpService constructor like this?

  constructor(backend: ConnectionBackend,
              private defaultOptions: RequestOptions,
              private httpCacheService: HttpCacheService,
              private authService: AuthService) {
    super(backend, defaultOptions);
  }

If it works for httpCacheService, it should work for your authService.

As for catching 401 error, you can just hook to the httpRequest or errorHandler methods.

[moshmage]

Yep, That's exactly how I set up - and what I thought ("if it works for httpCache it should work for auth")

I ended up making a layer between the Http and the app, httpClient, which will then call the Http. It's ugly, but I ain't have that much time;

Will revisit this approach later and submit a propper issue if stuff goes haywire :)

ps: My approach would also induce in a circular dependency, because HttpService required authService and authService required Http (which, if I understood the architecutre correctly.. is HttpService). So I guess that whatever I was doing, it wasn't correct ^^'

[sinedied]

ps: My approach would also induce in a circular dependency

Ah, that's the issue here! Since there's no way to properly resolve such dependencies, one of the required service ends up undefined. I'm surprised Angular did not throw some error or warning in the console though.

You should properly separate the 3 concerns here: getting authentified, storing/getting credentials and providing an customized http service. That should be 3 different services, and the service for storing/getting the credentials will act as the middleman here to avoid having a circular dependency.

Good luck ;)