Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku deployment fails :( #209

Closed
HaakonH opened this issue Jan 3, 2018 · 1 comment
Closed

Heroku deployment fails :( #209

HaakonH opened this issue Jan 3, 2018 · 1 comment

Comments

@HaakonH
Copy link

HaakonH commented Jan 3, 2018

I'm submitting a...

[ ] Bug report
[ ] Feature request
[X] Documentation issue or request

Current behavior

Upon deployment of app to heroku fails.

Expected behavior

Some sort of documentation about how to deploy to heroku.

Minimal reproduction of the problem with instructions

  1. Run ngx new and create a test app.
  2. Go to heroku and create a new application and click on the deploy tab.
  3. Login to heroku in your cmd window and then in the folder where you created your test app run the heroku git command to make it a heroku git app.
  4. Run the git add . then do a git commit -m 'initial commit'
  5. Then run - git push heroku master
  6. The app will build and push to heroku. A link will be generated in the script. If you click the link you will get an error.
  7. Looking in the logs on heroku or by running - heroku logs - in your command window will display:
    Failed at the test@1.0.0 start script.

Environment

- generator version: 3.1.1
- node version: 8.9.3  <!-- run `node --version` -->
- npm version: 5.5.1  <!-- run `npm --version` -->
- OS: Windows 7 Enterprise  <!-- Mac, Linux, Windows -->

Others:

@sinedied
Copy link
Member

sinedied commented Jan 4, 2018

Please take a look at https://medium.com/@hellotunmbi/how-to-deploy-angular-application-to-heroku-1d56e09c5147, it's not that simple: Heroku is not able to host a webapp directly, you need to provide a server.

You may take a look at Firebase and https://github.com/ngx-rocket/addon-firebase if you want a free hosting solution supporting webapp deployment directly.

While an Heroku deployment addon may be coming someday like the one for Firebase, it's outside the scope of the generator and it's already well documented on Medium, Stackoverflow and others.

@sinedied sinedied closed this as completed Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants