Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpCacheService.loadCacheData() #244

Closed
ausmurp opened this issue Feb 14, 2018 · 1 comment
Closed

HttpCacheService.loadCacheData() #244

ausmurp opened this issue Feb 14, 2018 · 1 comment
Labels
bug

Comments

@ausmurp
Copy link

ausmurp commented Feb 14, 2018

I'm submitting a...

[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

loadCacheData() currently sets this.cachedData with JSON.stringify(data) which is wrong.

Expected behavior

Should set this.cachedData with JSON.parse(data)

Minimal reproduction of the problem with instructions

Environment

vscode

- generator version: 3.2.1
- node version: 8.9.3
- npm version: 5.6.0
- OS: Windows

Others:
@sinedied sinedied added the bug label Feb 14, 2018
@sinedied
Copy link
Member

It was fixed with #237 and already merged on master, it will be available with upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sinedied @ausmurp