Added fallback to node.data to support server side translations via T… #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ranslateDirective
ocombe
reviewed
Dec 30, 2016
src/translate.directive.ts
Outdated
| } | ||
| node.currentValue = isDefined(res) ? res : (node.originalContent || key); | ||
| // we replace in the original content to preserve spaces that we might have trimmed | ||
| node.textContent = this.key ? node.currentValue : node.originalContent.replace(key, node.currentValue); | ||
| if(node.textContent) node.textContent = this.key ? node.currentValue : node.originalContent.replace(key, node.currentValue); | ||
| else node.data = _this.key ? node.currentValue : node.originalContent.replace(key, node.currentValue); |
There was a problem hiding this comment.
_this is undefined, that's why travis fails
There was a problem hiding this comment.
Oh! copy+paste from working file, my bad...
|
Thanks ! Can you fix the error ? |
|
Done :-) |
|
I can confirm that this issue is still present in v. 6.x.x and that the PR I had submitted still fixes it. Do you know if you will be able to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to make TranslateDirective work server side, see issue #377