Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal input migration converts observables in templates to signals #475

Open
jinder opened this issue Jul 30, 2024 · 0 comments
Open

Signal input migration converts observables in templates to signals #475

jinder opened this issue Jul 30, 2024 · 0 comments

Comments

@jinder
Copy link

jinder commented Jul 30, 2024

When an input has the same name as an observable (excluding $), the automatic migration will erroneously migrate this in the template.

Example

  @Input() public format: NumberFormatOptions;
  public readonly format$ = new BehaviorSubject(this.format);

Becomes:

  public format = input<NumberFormatOptions>();
  public readonly format$ = new BehaviorSubject(this.format());

Which is fine, except the template conversion this happens:

[format]="format$ | ngrxPush"

Becomes:

[format]="format()$ | ngrxPush"

Which is wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants