Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document situations where not pinning the nix version changes outputs #72

Open
nh2 opened this issue Dec 27, 2019 · 1 comment
Open
Assignees
Labels
question Further information is requested

Comments

@nh2
Copy link
Owner

nh2 commented Dec 27, 2019

In

# Full invocation, including pinning `nix` version itself.
I pin the version of nix itself.

I added that in the past because the upgrade from Nix 1.* to 2.0 created (if I remember correctly) different .drv files.

I would like to document cases beyond that which resulted in different .drvs or build outputs when the version of nix changes, so that I can justify to continue pinning nix:

.drv changes

  • During the ugprade from nix 1.* to 2.0

Output / build changes

@nh2 nh2 added the question Further information is requested label Dec 27, 2019
@nh2 nh2 self-assigned this Dec 27, 2019
@nh2
Copy link
Owner Author

nh2 commented Jan 27, 2020

I found another situation:

NixOS/nixpkgs#75676 (comment)

From Nix 2.2 to 2.3, nix changed to run its builds in a TTY (PR: NixOS/nix#2878) which can easily result in different build behaviour e.g. for Python:

Before, we'd get

('sys.stdout.encoding', None)
('sys.stdout.isatty()', False)

and afterwards we'd get

('sys.stdout.encoding', 'UTF-8')
('sys.stdout.isatty()', True)

and some code inspects that; in the linked case it led to a test failure in python2Packages.Babel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant